eu-digital-green-certificates/dgc-certlogic-android

[VH] Incorrect comparison of DCC version and rule version

mlenkeit opened this issue · 2 comments

Describe the bug

The current implementation is comparing the ver attribute of the DCC/hcert with the Version attribute of the rule:

hcertVersion == null || ruleVersion == null || hcertVersion.first != ruleVersion.first -> Result.OPEN

That's like comparing cars and apples.

Expected behaviour

Compare ver against SchemaVersion

Steps to reproduce the issue

look at the code

Technical details

n/a

Possible Fix

Compare ver against SchemaVersion

Additional context

n/a

LGTM!