euvl/vue-notification

Improve index.d.ts

Closed this issue · 1 comments

emiliskiskis commented

I develop with Vue + Typescript in my current project and I have noticed a few issues with the types defined in this project:

  1. The id property is missing from NotificationOptions
  2. If a custom name is provided for the notify function, the typings fail.

I propose a solution:

  1. Add the missing id property
  2. Remove the declare module part to let each user add it by themselves. Unfortunately, there is no way to do it automatically, especially with Vue.use.
github-actions commented

Stale issue message