evalEmpire/method-signatures

t/thread-bug.t crashes under 5.8.9 + threads

Closed this issue · 5 comments

MidLifeXis commented

This looks like an interaction where $Variable::Magic::VMG_THREADSAFE returns false, but where B::Hooks::EndOfScope::XS is loaded and assumes that V::M::VMG_THREADSAVE is true.

The user can set

$ENV{B_HOOKS_ENDOFSCOPE_IMPLEMENTATION} = 'PP';

but that causes other tests to fail, because the PP implementation does not implement the necessary featureset.

Update: Method::Signatures uses Data::Alias uses B::Hooks::EndOfScope uses Variable::Magic.

MidLifeXis commented

I personally think that this is a B::Hooks::EndOfScope bug. I don't like having the test push way down into Variable::Magic to see what its state is (see https://github.com/MidLifeXis/method-signatures/blob/threadbug_skip/t/thread-bug.t#L24). I suppose that I could mark this as a TODO, but I don't think that will save it from a segfault.

Any thoughts @schwern or @barefootcoder on a good way to address this?

Brian

MidLifeXis commented

Related issues:

  • #77 Make Data::Alias Optional
  • #58 Drop 5.8? New minimum 5.10.1?
barefootcoder commented

Any thoughts @schwern or @barefootcoder on a good way to address this?

I don't have any thoughts, personally ... @schwern?

eserte commented

This does not look like it's related to 5.8.9 (see my comment on #92).

barefootcoder commented

This should be fixed in 20140224. Please reopen if you still see problems.