evancohen/smart-mirror

map plugin draws empty frame on screen

sdetweil opened this issue · 2 comments

if you change the background color, there is a weird rectangle drawn on the screen.. its a page border type rectangle. this is drawn by the map plugin

Expected Behavior

if no map is requested,. no map or frame should be shown

Current Behavior

black frame is displayed

Possible Solution

Steps to Reproduce (for bugs)

install
edit app/css/main.css
change .body background-color to blue
restart smart-mirror
1.
2.
3.
4.

Context

Your Environment

  • Environment name and version (e.g. Raspberry Pi 3, node.js 5.4):
  • Operating System and version (e.g. Raspbian, Ubuntu, OSX):

if no geolocation info is set, geolocation returns incorrect info, and map plugin fails, but draws frame

steps to fix

  1. change map/index.html to ng-if="config.geolocation", only draw if location info set
  2. fix geolocation service to return proper error
  3. fix map plugin controller check for error

fixed 0.26