Add customizable User-Agent
flexd opened this issue · 8 comments
Hello.
CCP would very much like everyone to provide a User-Agent when talking to the API, so they know who to blame/contact if someone is banned/doing bad stuff :-)
15:13 %[CCP]FoxFour | Yes please
15:13 %[CCP]FoxFour | always add user agent :)
15:13 %[CCP]FoxFour | Me likes
15:15 %[CCP]FoxFour | No complaints 15:15 %[CCP]FoxFour | Just nice to know who to contact when things go book
15:15 %[CCP]FoxFour | :)
https://github.com/eve-val/evelink/blob/master/evelink/api.py#L307 Seems to be where it's needed.
I just wanted to ask here if anyone else think it's a good idea, and perhaps have an idea on how to add it :-)
Yes, definitely a good idea. It's just sending a header.
Great, good ideas are good! :-) I'm not entirely sure how to add a config option to set what evelink should send though. Preferably evelink + version + custom message saying who to contact if it's breaking stuff I guess.
This would indeed be very much appreciated! :D
This should probably be an option on API objects (like the API root url and
cache objects are).
No version number or anything for the library that I have seen though right?
Version number lives in evelink.__version__
On Mar 27, 2014 8:41 AM, "Regner" notifications@github.com wrote:
No version number or anything for the library that I have seen though
right?—
Reply to this email directly or view it on GitHubhttps://github.com//issues/162#issuecomment-38820250
.
God I am blind...
Will probably add this user-agent thing once my other pull requests go through if no one else does it.
Customizable user-agent functionality has been added as of ~3 days ago.