eveningkid/reacto

Remove componentWillMount, componentWillReceiveProps and componentWillUpdate usage throughout codebase.

frontendwizard opened this issue · 3 comments

frontendwizard commented

These methods are considered unsafe and bad practices and they'll eventually be deprecated and deleted. More info here: https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html.

eveningkid commented

Thanks for sharing, loved the article. It's actually interesting and will help for future projects!
I've counted about 20 components that will need to be updated, shouldn't take too long. I think it can be done later on, as long as we keep this in mind for any future component. There's still some time. :)

  • 👍1
eveningkid commented

I changed my mind.
I think it is actually a great idea to do this as soon as possible so it won't be done in a rush when these methods really become deprecated for good! I will take care of it this week and create a PR for it. :)

  • 👍1
  • ❤️1
eveningkid commented

Done with #84.
Only missing for the Editor component which will be done later on.
I really struggle to find free time for reacto right now, sorry guys.