Sales end date max is incorrectly calculated
Closed this issue · 8 comments
Expected Behavior
The max end date from sale is 2 weeks from the starting date from sale. Makes sense.
Actual Behavior
The max end date from a sale is 2 weeks... from the current time. It doesn't care about the starting date of the sale, meaning I can't make my haloween sales, meaning I'm not happy :(
Confirmed this to not just be me, seems to be a global site issue.
Reproduction Steps
1. Make addon
2. Make sale that ends in > 2 weeks from your current time
3. Loss.Browsers
Firefox 105.0.3 (64-bit)
Example URL
https://www.gmodstore.com/dashboard/teams/GBcrSGwgQLe5fImt2FscuA/sales/manage
GmodStore Version
v11.6.1
Event ID
No response
Additional Information
No response
I can no longer replicate this issue, if it still occurs feel free to reopen this issue 😄
This is still happening on my end, only letting me have 7 days after the sale start.
Hmmm strange, I'll retest this tonight.
I'm still unable to replicate this locally, laravel js validation must be misbehaving on my end.
I've applied a fix which should fix your validation problem (version 18.4.2), could you confirm that the issue is gone? 😄
Still there
I've noticed that this is only when it's doing the "realtime" clientside validation. Sometimes that validation breaks and doesn't say anything, allowing me to submit the form and your serverside validation gets it right allowing me to make a sale correctly.
When that wrong clientside validation gets in the way though your not allowed to submit the form at all.
Your observation is correct, it is indeed the clientside validation that is making the submission fail. I should've disabled the clientside validation on that field, did you verify the version I mentioned was already live by the time you tested?
Seems to be now ye, sorry forgot to CTRL + F5
Great, glad to hear 😀