evil-morfar/RCLootCouncil2

When ask leader for usage, the usage is asked twice.

Closed this issue · 1 comments

SafeteeWoW commented

When the addon asks usage for leader, usage is asked once when I become the leader, and then another immediately after when it switches me to Master Looter. Don't know why this does not occur when testing in 2man group.

evil-morfar commented

It's because of addon.lootMethod. Being leader marks you as ML. Entering a raid makes OnRaidEnter() show the popup, which runs StartHandleLoot(), which in turn switches loot method, that gets picked up by NewMLCheck(). Because of the the loot method check in line 1769 the function doesn't return even though the registered ML hasn't changed, and thus calls the popup again.

I see two ways of fixing this:

  1. Delete the loot method check - I don't think it's actually needed to check if that's changed? The only really relevant thing is the ML.
  2. Do a check for self.handleLoot == false before doing usage actions.