evilmartians/lefthook

Version 1.7.6 fails installation on CI

ipanasenko opened this issue · 4 comments

ipanasenko commented

🔧 Summary

Version 1.7.6 fails installation on CI, 1.7.5. works fine.
I have no issues with 1.7.6 locally on my mac.

We are using yarn 4.3.1.

Lefthook version

1.7.6 efa67f51e6a2d933dc539b2b1364eaade58351b5

Steps to reproduce

🤷‍♂️ Install in on Linux, I guess?

Expected results

Successful installation

Actual results

Installation fails

Possible Solution

🤷‍♂️

Logs / Screenshots

Error I see in our logs:

STDERR /home/builduser/work/61a1e8a640f7a0a3/node_modules/lefthook-linux-x64/bin/lefthook: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /home/builduser/work/61a1e8a640f7a0a3/node_modules/lefthook-linux-x64/bin/lefthook)
ditoglez commented

Same seems to happen for v1.7.7. Currently using lefthook with Vercel.

../.. postinstall$ lefthook install
../.. postinstall: /vercel/path0/node_modules/.pnpm/lefthook-linux-x64@1.7.7/node_modules/lefthook-linux-x64/bin/lefthook: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by /vercel/path0/node_modules/.pnpm/lefthook-linux-x64@1.7.7/node_modules/lefthook-linux-x64/bin/lefthook)
../.. postinstall: /vercel/path0/node_modules/.pnpm/lefthook-linux-x64@1.7.7/node_modules/lefthook-linux-x64/bin/lefthook: /lib64/libc.so.6: version `GLIBC_2.32' not found (required by /vercel/path0/node_modules/.pnpm/lefthook-linux-x64@1.7.7/node_modules/lefthook-linux-x64/bin/lefthook)
../.. postinstall: Failed
mrexox commented

That's bad. I've checked the artifacts and they must not use shared libs. I will try to figure it out. Thank you for submitting an issue.

  • 👍1
mrexox commented

Guys, my bad, I had a typo and built the lefthook executables with GCO_ENABLED=0 instead of CGO_ENABLED=0. With 1.7.9 version this issue must be resolved.

ipanasenko commented

1.7.9 works for me, thanks!