evilpie/add-custom-search-engine

Firefox Proton removes all page actions including "Add search engine"

Redfire75369 opened this issue · 15 comments

Following the steps on the add search engine page, I am unable to add the search engine as there is no "Add Search Engine" option.

Environment:
Windows 10 10.0.18363 Build 18363
Firefox Developer Edition 88.0b6

Still works for me in Nightly. Can you tell me the settings you used?

I did some testing because I had a slight suspicion it was caused by the Proton redesign.
The option browser.proton.urlbar.enabled=true resulted in the "Add Search Engine" option disappearing.

the Page Actions menu has been removed from the URLbar/awesomebar since Firefox ≥ 89.0b3 (Proton UI 🤮 )

setting [browser.proton.enabled = false](about:config) disabled the UI "improvements", but did not bring that menu back (and also hid its new location)

in the new Puketon.. I mean Proton: one has to Right Click on the urlbar and the Add Search Engine option appears there on first load.. sometimes

@Redfire75369 @evilpie could you edit this issue title to FIX "Add Search Engine" and its "Page Actions"/.../meatball menu missing in Firefox Proton (≥v89)

Thanks for reminding me. Having to right click is somewhat annoying to visualize :(

Hi, I'm running firefox nightly too and I do not see a way to actually add the new search engine. I tried setting browser.proton.enabled to false but as indicated above that did not seem to bring back the menu item. The right-click context menu also doesn't show the option. Am I missing this/reading it wrong?

Right clicking the address bar didn't work? It's working for me with proton enabled.

proton is enabled and the ight click menu looks as followed when clicked from (a) the extension "create new engine" page, and (b) a normal page, in this case on researchgate.
research-gate-page-r-click
extension-page-r-clickmenu

thanks for the quick response!

Weird, do you see anything in the browser console? (Ctrl+Shift+J)

This UI change appears to have been rolled out globally or something. I just got it and I'm not on any beta (that I know of).

I believe the issue is that adding the link element in JavaScript is no longer sufficient.

I performed the above test with researchgate, and I saw the same behavior. Add "ResearchGate search" appeared on that page, but nothing appeared on your extension.

I copied the two link elements into a local .html file. If I put in <link rel="search" type="application/opensearchdescription+xml" title="r" href="https://paste.mozilla.org/9EiMJrKP/raw"> (copied from the inspect element view), it worked fine and showed up. Same for <link rel="search" type="application/opensearchdescription+xml" title="ResearchGate search" href="https://www.researchgate.net/application.DownloadOpenSearchPlugin.html">.

I suspect/fear that Firefox changed something up internally, and now <link rel="search" only works if it is in the HTML on initial page load, and it won't show up if it's added later using JavaScript.

Still works fine for me, just have to right click. I am going to update the help text and screenshots tomorrow or so.

If you can reproduce this reliably it would be useful if you could take a look at the browser console (Ctrl+Shift+J)

Huh... I can't reproduce this anymore. I might have just been doing something wrong earlier today. Or some cache issue. Or your update.

Regardless, all seems well now, no issue anymore (at least for me) :) 👍

I am still having this issue...I've found the https://paste.mozilla.org link but have no idea how to add it. Nor do I know how to add the functionality for the custom search back to firefox.

I added the website's plugin but I'd prefer not to have to do so for every website, and of course there are websites that don't have one.