evilsoft/crocks

Errors should use a consistent voice

bennypowers opened this issue · 2 comments

bennypowers commented

Describe the bug
Following on #403 (comment), all errors should use a 🌽sistent voice, preferring active over passive voices where possible

Good:
"First argument must be a Number"

Bad:
"Number is required for first argument"

This is also an opportunity to fix capitalization and other grammatical nits in error messages.

To Reproduce
Filed as bug since changing errors is a change to API, however there's no repro- it's strings.

bennypowers commented

God-willing, I'll soon put together a PR to address this.

  • 😄2
dalefrancis88 commented

This is accepted and understood to be a core goal. Closing the issue