evindor/prettier-eslint-emacs

Incorrect arguments for latest version

jrdnull opened this issue · 1 comments

Thanks for this package, I'm not using those args so have just removed them in my vendored copy as the config options aren't currently used.

If you wanted to fix this for the latest version they need to be changed to e.g:

(defun prettier-eslint ()
  "Format the current file with ESLint."
  (interactive)
  (let ((options (prettier-eslint/options)))
        (progn (call-process
                (prettier-eslint/binary)
                nil "*Prettier-ESLint Errors*" nil
                buffer-file-name "--write" "--prettier.singleQuote"
                "--prettier.trailingComma=none" "--prettier.bracketSpacing=false")
               (revert-buffer t t t))))

And trailingComma now needs an argument otherwise it generates the warning:

Warning: `trailingComma` without any argument is deprecated. Specify "none", "es5", or "all".

This didn't seem to do any of the formatting in my case.