evolution-cms/installer

Temp directory needs trailing slash

sottwell opened this issue · 8 comments

sottwell commented

On some systems the extract will fail because the temp directory needs a trailing slash. Line 133.

terrybarth commented

So I have three different sites, all on Hostmonster, all setup at the same time. This worked on one site, but not the other two. Wouldn't these three have the same requirements?

Will some systems fail if there is always trailing slash on the temp directory?

sottwell commented

I don't know, I do know that adding the trailing slash solves the "failed to extract" error on some sites. I haven't used it enough since adding the slash to have it error again. For what it's worth, on my localhost MAMP it works either with or without the trailing slash.

sottwell commented

Apparently it depends on how the server is configured, how it will extract the files from the zip archive.

sottwell commented

I suppose it would just be trial-and-error, if it fails with the slash, try again without the slash...

terrybarth commented

Agree. I'll have to try it both ways. I have a few more upgrades to do so, I'll see what happens. Thanks!

sottwell commented

I'm also thinking of a try/catch, if it fails, try again the other way.

sottwell commented

I'm sorry I'm not making pull requests any more, but I am just using it for Revo install/upgrade now. Full credit given to your original, of course.

Feel free to go to my repository (sottwell/installer) and get the cURL code if you want it.