evryfs/github-actions-runner-operator

Metadata labels not accepted

Closed this issue · 2 comments

jarojasm95 commented

Using the following manifest to create a runner pool

apiVersion: garo.tietoevry.com/v1alpha1
kind: GithubActionRunner
metadata:
  name: my-runner-pool
spec:
  # minimum running pods, required
  minRunners: 1
  # max number of pods, required
  maxRunners: 6
  # the github org, required
  organization: jarojasm95
  # How often it will reconcile, optional, default 1m
  reconciliationPeriod: 1m
  # if runner for repo, optional
  # repository: "theRepoName"
  podTemplateSpec:
    metadata:
      labels:
        project: github-runner
    spec:
...

And the resulting pod does not contain the "project" label, the GithubActionRunner/my-runner-pool is also mutated to:

podTemplateSpec:
  metadata: {}
davidkarlsen commented

@jarojasm95 what version are you running? And do you have the latest CRD: https://github.com/evryfs/github-actions-runner-operator/blob/master/config/crd/bases/garo.tietoevry.com_githubactionrunners.yaml ?

GitHub
K8S operator for scheduling github actions runner pods - github-actions-runner-operator/garo.tietoevry.com_githubactionrunners.yaml at master · evryfs/github-actions-runner-operator
davidkarlsen commented

this should be ok by now.