evryfs/github-actions-runner-operator

Operator doesn't delete Evicted Pods.

Yagyansh opened this issue · 2 comments

Operator Version - v0.10.0

I'm using GHE.

When pods for a runner pool evict, the pods are successfully unregistered from Github but the pods aren't deleted and new pods aren't spun which leads to jobs being queued.
If I have 1 runner pod which gets evicted, then the CURRENTPOOLSIZE for the runner pool remains 1 which is why no new pod is spun.

I've already seen #232. This solves the evicted runners being unregistered, which is happening successfully but pods aren't being deleted.

@Yagyansh Evicted pods are a sign of something malfunctioning, hence k8s does not remove them automatically (in order to let the user detect the fact and understand why).

What does the logs of the operator say?

@davidkarlsen

I understand that, but when the operator has successfully de-registered the pod why isn't a new pod(i.e runner) being created?

I don't see any errors when the operator unregister the evicted pod.

Shouldn't the evicted pods be handled gracefully by the operator after #232 fix?