evryfs/github-actions-runner-operator

Add defaults to CRD

Closed this issue · 4 comments

davidkarlsen commented

https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#defaulting - when moving to apiextensions.k8s.io/v1 also add defaults for:

  • reconciliationPeriod (1m)
  • minRunners (1)
  • maxRunners (1)
RichiCoder1 commented

Per this, how much of the pod spec template is required?

davidkarlsen commented

Not sure I follow? Do you mean how much is required to be defined as of today?
if so, min and max.

RichiCoder1 commented

Not sure I follow? Do you mean how much is required to be defined as of today?
if so, min and max.

Exactly. Good to know, the example just makes it seem as if everything is required at this second. Ty!

davidkarlsen commented

Thanks, added docs in 7c66110