ewg118/numishare

Manual Findspot coordinates seems not working

Closed this issue · 9 comments

fgnm commented

Hi Ethan!
While testing a new installation of numishare (based on latest commit) I noticed that when set the findspot to manual coordinates information don't appears on the map nor in any kind of export, while if I set them with Geonames it works. Is there something I need to enable first/setup first to enable manual coordinates?
Thanks

I see in the NUDS->GeoJSON XSLT where the manual coordinates are not being represented. However, the NUDS model uses gml:coordinates, which has been deprecated and replaced with gml:pos. How many coins have you entered with manual coordinates? If it's not many, I should transition to the current GML schema and update the XForms backend and XSLT stylesheets accordingly.

fgnm commented

Many thanks! Currently, I'm just testing all functionalities, so only some tests has been done. If this could be fixed would be very appreciate :)

OK, I have updated the model. Now when you insert manual coordinates, the GML structure of gml:location/gml:Point/gml:pos is created, following the model already established for coordinates within nuds:findspot/nuds:fallsWithin to manually embed coordinates extracted from gazetteer systems like Geonames or Wikidata. All of the different serializations that rely on the new GML model have been updated, so the coordinates should now be visible in the maps with GeoJSON and be indexed into Solr for the map browsing interfaces.

fgnm commented

Thanks so much for the quick fix! It works well expect for the coin details page in which the map isn't still visible with manual coordinates, but I confirm that in the main Maps section I can now see the manual findspots.

fgnm commented

Yes, I can see the coordinates using .geojson, and the map appears when the mint field is provided (I can see both mint and findspot in the map btw). I don't know if it's a bug or an intended behavior, but the map doesn't show when only the findspot is provided.

OK, try again now with only a findspot and not a mint.

fgnm commented

Perfect! Thank you :)