excid3/madmin

Relax Pagy dependencies

Closed this issue · 1 comments

gathuku commented

@excid3 Pagy has released a lot last month https://rubygems.org/gems/pagy/versions, would you like to relax dependencies.

madmin/madmin.gemspec

Line 22 in 5ef1dfd

spec.add_dependency "pagy", ">= 3.5", "< 5.0"

excid3 commented

It always depends on what the breaking changes are.

Looks like 5.0 introduced a few: https://github.com/ddnexus/pagy/blob/master/CHANGELOG.md#breaking-changes---1-code-update

If we update the Madmin code, we can change to support >= 5.0 and < 6.0