execuc/LCInterlocking

Maximum recursion depth exceeded in comparison

Closed this issue · 8 comments

Starting from a blank project in Freecad 0.19 daily, navigating to the Laser Cut Interlocking workbench, and clicking the "Make box without tab" button, I get the following in the Report View:

`Traceback (most recent call last):
File "/usr/share/freecad-daily/Mod/LCInterlocking/MakeBoxPanel.py", line 51, in onChanged
if prop == "recompute":
<class 'RecursionError'>: maximum recursion depth exceeded in comparison
Running the Python command 'make_box_command' failed:
Traceback (most recent call last):
File "/usr/share/freecad-daily/Mod/LCInterlocking/MakeBoxPanel.py", line 192, in Activated
vp.setEdit(ViewProviderGroupBox)
File "/usr/share/freecad-daily/Mod/LCInterlocking/MakeBoxPanel.py", line 85, in setEdit
FreeCADGui.Control.showDialog(MakeBox(self.Object))
File "/usr/share/freecad-daily/Mod/LCInterlocking/MakeBoxPanel.py", line 153, in init
self.preview()
File "/usr/share/freecad-daily/Mod/LCInterlocking/MakeBoxPanel.py", line 172, in preview
self.obj_box.recompute = True

maximum recursion depth exceeded in comparison`

Python console displays the following:

`Python 3.6.8 (default, Aug 20 2019, 17:12:48)
[GCC 8.3.0] on linux
Type 'help', 'copyright', 'credits' or 'license' for more information.

Gui.runCommand('Std_ViewStatusBar',1)
Gui.runCommand('Std_ViewStatusBar',0)
Gui.runCommand('Std_Workbench',18)

Begin command Std_New

App.newDocument("Unnamed")
App.setActiveDocument("Unnamed")
App.ActiveDocument=App.getDocument("Unnamed")
Gui.ActiveDocument=Gui.getDocument("Unnamed")
Gui.activeDocument().activeView().viewDefaultOrientation()

End command Std_New

Gui.runCommand('Std_OrthographicCamera',1)

Begin command Std_Workbench

Gui.activateWorkbench("LCInterlockingWorkbench")

End command Std_Workbench

Gui.runCommand('make_box_command',0)
Gui.runCommand('Std_About',0)
`

My version and OS info here:

OS: Ubuntu 18.04.3 LTS (ubuntu:GNOME/ubuntu) Word size of OS: 64-bit Word size of FreeCAD: 64-bit Version: 0.19. Build type: Release Python version: 3.6.8 Qt version: 5.9.5 Coin version: 4.0.0a OCC version: 7.3.0 Locale: English/UnitedStates (en_US)

Same thing occurs if I try "Make rounded box without tab"

Ok, sorry for the issue. I would test when I could.

@execuc can you recreate this?

Yes I have the problem in 0.19, I will investigate. Sorry for the problem.

Ok I have corrected the problem in the last commit.

Ok I have corrected the problem in the last commit.

What commit is the fix in?

Sorry, I had a problem in the last commit. I just commited it.