Students are able to compile code that is longer than 80 columns with fixed-form

Question

Students are able to compile code that is longer than 80 columns with fixed-form

Opened this issue 2 years ago · 5 comments

KTSnowy commented 2 years ago

I thought that gnuCOBOL's default option maintained the fixed-form column length limit.

Answer 1 · 2022-07-29T17:21:28.000Z

@0xE282B0 do you know if cobol-check has any options to maintain the column limit?

Answer 2 · 2022-07-29T17:47:04.000Z

We found out that the line limits are not hit because cobolcheck reformats the code.

Before cobolcheck:

         IF FUNCTION MOD ( WS-YEAR, 4 ) = 0 AND FUNCTION MOD ( WS-YEAR, 100 ) > 0 OR FUNCTION MOD ( WS-YEAR, 400 ) = 0 
            MOVE 1 TO WS-RESULT
         ELSE
            MOVE 0 TO WS-RESULT.

After cobolcheck:

           IF FUNCTION MOD ( WS-YEAR, 4 ) = 0 AND FUNCTION MOD (                
               WS-YEAR, 100 ) > 0 OR FUNCTION MOD ( WS-YEAR, 400 ) = 0          
            MOVE 1 TO WS-RESULT                                                 
         ELSE                                                                   
            MOVE 0 TO WS-RESULT.

Answer 3 · 2022-07-29T17:57:10.000Z

@KTSnowy This behavior is not configurable, see: https://github.com/openmainframeproject/cobol-check/blob/main/src/main/java/org/openmainframeproject/cobolcheck/features/writer/CobolWriter.java#L36-L47
But that would be easy to change.

Answer 4 · 2022-07-29T18:22:05.000Z

But that would be easy to change.

Would it be alright if you make a temporary fork to test it?
If it works we can keep using the fork for our track.

Answer 5 · 2022-07-29T18:47:37.000Z

Sure, just need to see when I can get to that.