International Calling Connoisseur - Many passing solutions logically incorrect

Question

International Calling Connoisseur - Many passing solutions logically incorrect

Closed this issue 2 years ago · 4 comments

While looking at existing solutions for this problem I noticed a lot of them use existingDictionary.Values.Max() to find the longest country name. This only work by coincidence as the longest country name also happens to be last of the entries alphabetically.
Perhaps different values should be chosen to populate existingDictionary or the tests updates to catch this.

Answer 1 · 2022-07-07T08:10:37.000Z

That is a great suggestion! Would you be willing to submit a PR to fix this?

Answer 2 · 2022-07-07T17:03:42.000Z

Sure, I'll give it a go

Answer 3 · 2022-07-07T20:19:40.000Z

It's my first submission so please let me know if I need to update anything.

Answer 4 · 2022-07-12T07:24:31.000Z

Everything was good! I've just merged the PR. Thanks.