template track's bin/fetch-configlet needs to be case-insensitive to `Location:`
petertseng opened this issue · 3 comments
Current version of template bin/fetch-configlet is case-sensitive on Location:
: https://github.com/exercism/request-new-language-track/blob/6e98d13765f0d361603088dcb9999e0baab6cddd/bin/fetch-configlet#L29
However, since GitHub started outputting lowercase location:
in February 2020 (reported exercism/configlet#173), this template bin/fetch-configlet won't be able to determine the $VERSION.
Thus, template track's bin/fetch-configlet should be updated to be case-insensitive wrt Location:
. Otherwise, every new track has to reapply the fix, which is an unnecessary hurdle to getting a track running.
That was probably fixed by #76. Not sure, but I'll assume it's good.
No need to assume. I tested the get_url
in https://github.com/exercism/request-new-language-track/pull/76/files#diff-57a7929c2bd4459c8faf8ae831fc7c8aR37-R40 and find that it is not susceptible to the problem. So this issue is confirmed to be fixed.
Great. Thank you! 🙂