exoframejs/exoframe

Default ignores/.exoframeignore doesn't work on Windows

HTLFabian opened this issue · 2 comments

I was wondering why the deployment process always takes so long, and then I found out node_modules wasn't excluded. I tracked down where the issue resides, and here is the cause:

const relativePath = name.replace(`${workdir}/`, '');

It only replaces the workdir followed by a /, but on Windows it won't do anything because of the best feature Windows has to offer (\ in the path).

@HTLFabian right, I guess it'd be better to use path package for that stuff to make it cross-platform 🤔
I'll look into it once I have some free time. PR is very welcome :)

Ready for release in the next update thanks to @FDiskas