Stats row `<tr class="stats-th">` still visible even when there's no summary for the QueryResult
ernstki opened this issue · 5 comments
Hi all, hope you're doing well. I plan on doing a PR for this.
In the latest release (3.2.1) the <tr class="stats-th"> in explorer/templates/explorer/preview_pane.html is displayed even when there are no recognized numeric columns, i.e., explorer.models.QueryResult.process_columns doesn't add a .summary. This isn't a tragedy, obviously, but I think it's probably still a bug.
I should be able to fix that by just relocating the conditional in the template, no problem.
In the same PR, I also intend to remove this chunk of extra space within each <td>, by just trimming some whitespace in the template. I know that gobs of extra whitespace is en vogue these days, but I think this was just an accident. ;)
The question I have, though, is how do I do a PR for the 3.x series? The master branch seems to be moving fast toward a new release with breaking changes, and I ran into some problems trying to patch master, which I don't think I'm qualified to resolve (JavaScript stuff).
Can I just do a PR against 3.2.1, or should I just cool out for a while until master is more stabilized?
Hi @ernstki, you're right. The frontend has had a revamp so I think master is headed for v4
I think what we'll need to do is create a branch for 3.x support. I may be able to set this up soon. Otherwise I'll sort tomorrow (I'm on UK time, approaching 1am)
@marksweb OK, super, thanks. That's a relief.
No rush. We can just override the template in our own application with the fixes in the meantime, and it's just a visual appearance thing anyway.
Ok I've setup a support/3.x branch;
https://github.com/chrisclark/django-sql-explorer/tree/support/3.x
Start a branch from there and we can release safely.
In the same PR, I also intend to remove this chunk of extra space within each
<td>, by just trimming some whitespace in the template. I know that gobs of extra whitespace is en vogue these days, but I think this was just an accident.;)
Turns out this occurs only when EXPLORER_UNSAFE_RENDERING = True, which probably accounts for why it went under the radar for a little while.