expo/vscode-expo

Check if we can only activate when workspace has `app.json` or `app.config.json`

byCedric opened this issue · 4 comments

byCedric commented

Old version

Right now it's activated on all events.

New version

It should only happen when Expo is found in the project.

Additional context

It's not necessarily a waste, but good dev-hygiene 😄

JB1905 commented

I can take it 🙂

  • 👍1
byCedric commented

Sorry for the delay again! If you want, go for it 😄 I'm not an expert with VSCode plugins. I know there are some interesting activation events that we can use, but looking forward to any contribution 👍

  • 👍1
ekfuhrmann commented

Is there any progress on this feature? While working on multiple projects unrelated to Expo, it is a bit annoying always getting an error on VSCode bootup.

byCedric commented

@ekfuhrmann This has been sort-of implemented already.

  • We defer starting up to keep vscode as fast as possible (source - see why)
  • The JSON Schema only activates for app.json (source)
  • We fixed an issue where app.json's expo was required and would warn if it's not defined (#63)

This is as specific as we can get it. If you know a better way, feel free to open a new issue.