expo/vscode-expo

App json set to "JSON" language, and not "JSON5"

byCedric opened this issue ยท 3 comments

Description of the bug

The app.json is set to default JSON, while the app manifest is parsed as JSON5.

To Reproduce

Open app.json, add a comment (JSON5 feature)

Expected behavior

The plugin would set JSON5 instead of requiring it to do that manually.

Actual behavior

Errors on the JSON comment

closing, this would probably confuse users

Now that EAS supports json5, I'm reopening this to enable this from the extension. Luckily, we use jsonc-parser which supports comments as well, so no changes required from within the extension.

๐ŸŽ‰ This issue has been resolved in version 0.9.1 ๐ŸŽ‰

The release is available on GitHub release

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€