exposebox/node-thrift2-hbase

generic-pool _waitingClients size has been growing

Closed this issue · 4 comments

kuake commented

like:

hbasePool.acquire(function(err, hbaseClient){
    //**Shortly after the start can not executed here**
});

Shortly after the start, I can't put anything to hbase
and I find generic-pool _waitingClients size has been growing.
How to find the problem?
Thanks for your reply

moshewe commented

Can you supply the exact code you were using?
Did you use require('node-thrift2-hbase')(config) or some internal file within the library?

kuake commented

sory, new code forget to
hbasePool.release(hbaseClient);

kuake commented

do you plan to update generic-pool to 3.x ?

moshewe commented

Exactly in order to avoid this issue, we've implemented functions that perform HBase queries for you, so you won't have to handle the client directly - scan, getRow, incRow and putRow. The client pool is there for the internal implementation of these functions. I'll update the usage examples to reflect this change.

You are welcome to update generic-pool to 3.x and make a pull request :-) Do you see any significant gain to be had by updating that library?