external-secrets/kubernetes-external-secrets

Support Azure China Cloud

Closed this issue · 3 comments

goldginkgo commented

The kubernetes-external-secrets seems to be not working with Azure China Cloud.
According to Azure documentation https://docs.microsoft.com/en-us/azure/key-vault/general/security-features#privileged-access, Azure China has different endpoints.

Global:
<vault-name>.vault.azure.net:443

Azure China 21Vianet:
<vault-name>.vault.azure.cn:443

But from the code, it is only pointing to the Azue global endpoint https://github.com/external-secrets/kubernetes-external-secrets/blob/master/lib/backends/azure-keyvault-backend.js#L20.

Is there any workaround for this?

Thanks.

moolen commented

That's not possible yet, but really easy to configure as you have found out already (same issue as #764 )

github-actions commented

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions commented

This issue was closed because it has been stalled for 30 days with no activity.