fNIRS/snirf

Release version 1.1.0

Closed this issue · 7 comments

rob-luke commented

Once the following issues are resolved I suggest we release a new version 1.1.0:

In addition to the issues above, here is the changelog since version 1.0:

  • Add dataUnit to indexed groups aux and measurementList
  • Uses of the word "numerical" were replaced with "numeric" for consistency.
  • stim/data was incorrectly described as [<f>,...]+ in the table when it should be [[<f>,...]]+
  • aux/dataTimeSeries was incorrectly described as [[<f>,...]]+ in the table when it should be [<f>,...]+
  • aux/dataTimeSeries and aux/time were described as numeric in the document when they should be 1-D numeric array
  • probe/detectorPos2D was described as numeric in the document when it should be 2-D array

Additionally, we now have the wonderful validator, so that's great too.

Thoughts @sstucker @dboas ?

sstucker commented

Sounds good! I'll have #99 merged by your tomorrow :)

rob-luke commented

No rush! 2 minutes was a faster turn around than I was expecting 😉

sstucker commented

Okay! We just bit the bullet on lots of changes!

Let's let the dust settle for a bit. I'll generate and test some code based on the new spec and make sure we're not missing something.

rob-luke commented

Probably worth ticking off #81 if we can too. I agree to waiting a bit for us to test it before releasing.

sstucker commented

By merging #86 ?

rob-luke commented

By merging #86 ?

I think it still needs some work, I might get a chance to look at it later this week.

sstucker commented

I think we are ready for v1.1. I will draft a release PR.

  • 🎉1