fabianmichael/kirby-typography

typography.diacritics.custom [documentation]

anthonymasure opened this issue · 7 comments

anthonymasure commented

Can you provide an exemple for "typography.diacritics.custom" ? I want to use it in French recommended Settings but it doesn't work. Also, "typography.punctuation.spacing.french" doesn't seems to add thin spaces inside French quotes (ex. : « foo »).
Thanks!

fvsch commented

I think the "typography.punctuation.spacing.french" not adding thin spaces was a limitation of the php-typography class (from wp-typography), addressed here:

mundschenk-at/wp-typography#36
and possibly related issue:
mundschenk-at/wp-typography#32

That being said, these fixes were in 3.3.0 of wp-typography and should be in beta1 of this plugin. But when I tried using this plugin for French text, it seems that the php-typography class still had issues with adding or converting non-breaking spaces in French text, especially when there were several punctuation marks following each other. Like "Salut!" or « Salut ! » not getting non-breaking spaces added/converted reliably.

I’d have to run more comprehensive tests with php-typography first, then with this plugin, so see where stuff is going wrong.

anthonymasure commented

Thank you, I'll test again in the next plugin version!

fabianmichael commented

Sorry, that I’ve been so quiet for a while now. Just to let you know: I am currently too occupied with other projects, so I did not find enough time continue my work on Kirby-Typography yet. But I haven’t abandonded this plugin, as I’m using it for my own and my client projects. I will continue to suport it, but the next fixes and updates will have to wait – probably – until October 2016. Thanks for your patience.

  • 👍1
anthonymasure commented

Thanks to both of you, I'll wait until then.

mundschenk-at commented

It would be great if you could report problematic strings directly in mundschenk-at/wp-typography (just open a new issue there). Just make sure that you include all relevant settings (i.e. at least those from the same section) in the bug report.

anthonymasure commented

Is it fixed?

fabianmichael commented

Oh, that was a bit too fast. My inital plan was to tinker on it at IndieWebCamp last weekend to finally make a new release, but I couldn’t finish it yet.