Parameters for configuring word length, phrase length, vector weight.

Question

Parameters for configuring word length, phrase length, vector weight.

Closed this issue 7 years ago · 9 comments

celestelynpaul commented 7 years ago

It would be nice if this version supported some of the parameters like the Zelandiya implementation.

paladini commented 7 years ago

+1

fabianvf commented 7 years ago

yep

Answer 1 · 2017-07-18T21:44:07.000Z

List the parameters you want and what they do and I'll see what I can do

Answer 2 · 2017-07-19T16:54:51.000Z

Think changes are addressed in this PR: #9

Answer 3 · 2017-08-01T19:16:39.000Z

@fabianvf is this fixed?

Answer 4 · 2017-08-01T19:19:46.000Z

If it is we need to put it in the readme

Answer 5 · 2017-08-01T19:47:22.000Z

@justinkterry it is not, I have some changes in a PR here: #16

But wanted to get your thoughts on it before merging in case it breaks you.

Answer 6 · 2017-08-01T19:58:44.000Z

I'm half way through a pull request for all the other things I was talking about, let's get that happy and merged and then come back to that. Also would we be better off using pickle under the hood for the word list functions instead of having it return lists like it does now?

…

On Tue, Aug 1, 2017 at 3:47 PM, Fabian von Feilitzsch < ***@***.***> wrote: @justinkterry <https://github.com/justinkterry> it is not, I have some changes in a PR here: #16 <#16> But wanted to get your thoughts on it before merging in case it breaks you. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#11 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AShd7Fss8FM4_IRSbvZP2iNW5h7cRsa7ks5sT4DKgaJpZM4NUalp> .

-- Thank you for your time, Justin Terry

Answer 7 · 2017-11-01T05:41:29.000Z

@fabianvf didn't my last giant PR close this?