fabiocaccamo/django-admin-interface

missing check for show_inlines_as_tabs in template

amuzhdaba opened this issue · 2 comments

amuzhdaba commented

There is missing check for the show_inlines_as_tabs condition in the change_form.html (lines 66-73)
So even if I have this feature turned off it populates tabcontent blocks with inlines formsets.
At the same time corresponding condition check for the tablinks is not missing so you'll never see that hidden tabcontent blocks were populated.

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
fabiocaccamo commented

@amuzhdaba thank you for reporting this, this feature is hard to maintain because writing tests for it is a bit complicated (#301).

Do you want to submit a PR for fixing this issue?

fabiocaccamo commented

@amuzhdaba fixed in 0.28.0 version.