fabiospampinato/noop-tag

Usage with `String.raw`

Closed this issue · 4 comments

DCzajkowski commented

I think this package could utilize the built-in String.raw, which should be faster than the current implementation.

MDN reference: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/raw#building_an_identity_tag

fabiospampinato commented

IIRC I had tried that at one point and it was actually slower for some reason 🤔 It's worth a second attempt though, maybe it got optimized since then.

DCzajkowski commented

I haven't tried it so you might be right. 😅 I assumed native implementation should be faster, but that may not be the case.

fabiospampinato commented

As of today the built-in way of doing this takes ~500ms in my benchmark, vs the ~70ms that my implementation takes 🤷‍♂️

  • 👀1
fabiospampinato commented

This seems to take some ~330ms:

function noop (): string {

  if ( arguments.length < 2 ) return arguments[0];

  arguments[0] = { raw: arguments[0] };

  return String.raw.apply ( String, arguments );

}

It's still way slower than my implementation, so nothing to do here I guess.

  • 👍1