fabiospampinato/vscode-todo-plus

"todo.embedded.view.sort": "label" does not work as expected

Opened this issue · 3 comments

Repro step

  1. Edit vscode settings.json
  2. Add a key/value pair of: "todo.embedded.view.sort": "label",
  3. Add some todo items like: // TODO: 1. foo at the bottom of a file, // TODO: 2. bar at the top of a file

Observed vs expected behavior

  1. The embedded todo views will show the todos in line order and not label sort order, which is what I was expected having set todo.embedded.view.sort to label.
    1. I was expecting TODO: 1. foo to be at the top of the todo embedded view and TODO: 2. bar to be at the bottom.
    2. But it was the opposite (which is what the result should be if sort order is line).
  2. It looks like https://github.com/fabiospampinato/vscode-todo-plus/blob/master/src/views/embedded.ts#L80 is probably doing the right thing, so I'm not sure what is going on to cause this issue 🤔.

Debugging attempt

I thought maybe the todo.embedded.provider was impacting this somehow. My default is set to rg, so I changed it to javascript and observed the same behavior. So changing the provider doesn't seem to have any impact.

Can you post a screenshot of the result so that we are exactly on the same page?

Can you post a screenshot of the result so that we are exactly on the same page?

image

Ok that doesn't look right 🤔