fabric8-launcher/launchpad-addon

wizards for spring boot + WF Swarm should default to adding liveness checks + readiness checks OOTB

jstrachan opened this issue · 4 comments

jstrachan commented

All apps on kubernetes/openshift should have liveness + readiness checks (along with jolokia + prometheus endpoints). While we at it logging should always be to stdout/stderr and ideally would use JSON markup for easy ingestion into ELK without fragile regex.

The OOTB defaults for projects created by obsidian should be for good cloud native defaults.

So for spring boot that means defaulting to always add the spring boot actuator so that fmp generates the liveness + readiness checks.

cmoulliard commented

@jstrachan As the enhancement suggested here concerns WildFly Swarm, Spring Boot & potentially Vert.x I will create a jira OBST ticket & trello card to keep track of that. By consequence, this issue will be closed.

jstrachan commented

@cmoulliard whatever you think is best. e.g. for spring boot I figured we'd just default the actuator in the dependency selection wizard OOTB

ALRubinger commented

@cmoulliard How do you want to coordinate this? Separate issues for each Booster impl which needs work done?

gastaldi commented

I believe this is already done? Can someone confirm?