Approve step outside of a mavenNode{...} definition doesn't terminate build pod

[rawlingsj]

Testing Using a Jenkinsfile of:

#!/usr/bin/groovy
@Library('github.com/fabric8io/fabric8-pipeline-library@master')
def dummy
mavenNode{
  container('maven'){
    echo 'inside build pod'
  }
}
node{
    approve {
      room = null
      version = '1.0.0'
      console = null
      environment = 'Stage'
    }
}

The build pod is kepy running until the jobs has finished rather than at the closing parenthesis of the mavenNode, this means that build pods will stick around during the approve step which is a waste of resources.

@iocanel suggested trying this fabric8io/kubernetes-plugin@2b4f6d8 which works great. I wonder however if instead we need to mark the build pod as complete list the openshift s2i build pods?

[jstrachan]

@rawlingsj this now fixed?

[rawlingsj]

yep it's fixed