facebook-csharp-sdk/facebook-winclient-sdk

What is the process for pulling in contributions?

Closed this issue · 2 comments

sanjeevdwivedi commented

@prabirshrestha @ntotten What is the established process for pulling in changes? Did you guys used to verify user submitted contributions before pulling them in?

prabirshrestha commented

We do review the code before merging in.

Here are some notes from old emails with outercurve.

The process is documented under the developer IP guidelines here: http://www.outercurve.org/About/DevelopmentPractices

It looks like for small fixes and documentation we don't need to have people sign a CLA, correct? If that is the case, right now I think we are good. Nobody has yet contributed anything more than a few lines or some updates to the docs.
Correct. There are short changes that could trigger a CLA, but I'm trusting you (and all projects' committers) to know the difference between a quick fix and something that is a few lines of genuinely brilliant expressive work.

Just cc me any PRs you want me to review.