Some declarations of common sensor functions are not matched to their corresponding definitions.
Scron-Chang opened this issue · 0 comments
Scron-Chang commented
I got some error messages from the Build and Analyze: run-cppcheck task.
Files to check:
common/service/sensor/sensor.c
Errors Found:
common/service/sensor/sensor.c:274:26:Function 'stby_access' argument 1 names different: declaration 'sensor_num' definition 'sensor_number'.
common/service/sensor/sensor.c:279:24:Function 'dc_access' argument 1 names different: declaration 'sensor_num' definition 'sensor_number'.
common/service/sensor/sensor.c:284:26:Function 'post_access' argument 1 names different: declaration 'sensor_num' definition 'sensor_number'.
common/service/sensor/sensor.c:289:24:Function 'me_access' argument 1 names different: declaration 'sensor_num' definition 'sensor_number'.
The root cause should be some declarations don't match their corresponding definition.
For instance,
OpenBIC/common/service/sensor/sensor.c
Lines 272 to 275 in 6e194a7
OpenBIC/common/service/sensor/sensor.h
Line 219 in 6e194a7
What would you suggest to handle this issue?