facebook/duckling

A.M. / P.M. mistake in an hourly time range

belamenso opened this issue · 2 comments

Offending examples: 08h00 - 11h30

Command:

curl -XPOST http://0.0.0.0:8000/parse --data 'locale=fr_CH&text="08h00 - 11h30"'

Result:

[
   {
      "body":"08h00 - 11h30",
      "start":1,
      "value":{
         "values":[
            {
               "to":{
                  "value":"2021-09-04T23:31:00.000-07:00",
                  "grain":"minute"
               },
               "from":{
                  "value":"2021-09-04T20:00:00.000-07:00",
                  "grain":"minute"
               },
               "type":"interval"
            },
            {
               "to":{
                  "value":"2021-09-05T11:31:00.000-07:00",
                  "grain":"minute"
               },
               "from":{
                  "value":"2021-09-05T08:00:00.000-07:00",
                  "grain":"minute"
               },
               "type":"interval"
            },
            {
               "to":{
                  "value":"2021-09-05T23:31:00.000-07:00",
                  "grain":"minute"
               },
               "from":{
                  "value":"2021-09-05T20:00:00.000-07:00",
                  "grain":"minute"
               },
               "type":"interval"
            }
         ],
         "to":{
            "value":"2021-09-04T23:31:00.000-07:00",
            "grain":"minute"
         },
         "from":{
            "value":"2021-09-04T20:00:00.000-07:00",
            "grain":"minute"
         },
         "type":"interval"
      },
      "end":14,
      "dim":"time",
      "latent":false
   },
   {
      "body":"30\"",
      "start":12,
      "value":{
         "second":30,
         "value":30,
         "type":"value",
         "unit":"second",
         "normalized":{
            "value":30,
            "unit":"second"
         }
      },
      "end":15,
      "dim":"duration",
      "latent":false
   }
]

I suppose that from the '0' preceding the 8 we should be able to contextually determine that it's an AM time?

Yes, I would say that 08h00 - 11h30 is the precise expression in the 24-hour format.