facebook/folly

fbcode_builder should be synced to the mcrouter repo

Opened this issue · 1 comments

In #2268, I added fbcode_builder manifests for https://github.com/facebook/mcrouter to facilitate adding a CMake build system on top of it in facebook/mcrouter#449. Now that the PR has been merged, the changes have been propagated to several repositories that use fbcode_builder, but not mcrouter.

Could mcrouter be setup with fbcode_builder as well like those repos?

Thanks in advance!

I've noticed that the manifest I added in #2268 was missing some metadata required for mcrouter to be correctly recognized as a Meta first-party project. I've just submitted a PR to add those—not sure if that'll in itself be sufficient to resolve this issue or if some other work is needed.