facebook/litho

TreeProp updates aren't given to children inside Sections

DSteve595 opened this issue · 1 comments

Version

0.40.0

Issues and Steps to Reproduce

Make a component that receives a TreeProp. Render that component inside a section. Update the component tree to have a newer TreeProp value. Observe that the component doesn't rerender with the new value for the TreeProp.

Expected Behavior

The component should rerender with the updated TreeProp.

Link to Code

Sample project

I'm unfortunately not surprised about this, however I don't think we are going to have time to work on fixing this in the near future. I'd suggest to either try to keep TreeProps for things which are static (e.g. a log tag, a toolbox, a logger, etc) for now unless you're feeling really motivated to dig in and send a PR :) I think we do need to fix this in the longer term and it's an important issue, we're just a bit constrained atm.