mcrouter build fails for Ubuntu 20.04: AtomicQueue.h: No such file or directory

[pavars]

Hi,
I tried building the Docker image with Ubuntu 20.04 from master branch, a couple of issues there (some manual fixes in Dockerfile fixed that, like installing sudo and tzdata package in noninteractive mode) but the biggest being missing lib which unfortunately I cannot fix:

#5 1550.3 [ 68%] Building CXX object thrift/lib/cpp2/CMakeFiles/thriftcpp2.dir/GeneratedCodeHelper.cpp.o
#5 1550.7 In file included from /usr/local/mcrouter/pkgs/fbthrift/thrift/lib/cpp2/async/ClientStreamBridge.h:22,
#5 1550.7                  from /usr/local/mcrouter/pkgs/fbthrift/thrift/lib/cpp2/async/ClientBufferedStream.h:23,
#5 1550.7                  from /usr/local/mcrouter/pkgs/fbthrift/thrift/lib/cpp2/async/ServerStream.h:25,
#5 1550.7                  from /usr/local/mcrouter/pkgs/fbthrift/thrift/lib/cpp2/async/ResponseChannel.h:29,
#5 1550.7                  from /usr/local/mcrouter/pkgs/fbthrift/thrift/lib/cpp2/async/ReplyInfo.h:20,
#5 1550.7                  from /usr/local/mcrouter/pkgs/fbthrift/thrift/lib/cpp2/async/AsyncProcessor.h:39,
#5 1550.7                  from /usr/local/mcrouter/pkgs/fbthrift/thrift/lib/cpp2/GeneratedCodeHelper.h:33,
#5 1550.7                  from /usr/local/mcrouter/pkgs/fbthrift/thrift/lib/cpp2/GeneratedCodeHelper.cpp:19:
#5 1550.7 /usr/local/mcrouter/pkgs/fbthrift/thrift/lib/cpp2/async/TwoWayBridge.h:24:10: fatal error: folly/experimental/channels/detail/AtomicQueue.h: No such file or directory
#5 1550.7    24 | #include <folly/experimental/channels/detail/AtomicQueue.h>
#5 1550.7       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#5 1550.7 compilation terminated.
#5 1550.7 make[3]: *** [thrift/lib/cpp2/CMakeFiles/thriftcpp2.dir/build.make:89: thrift/lib/cpp2/CMakeFiles/thriftcpp2.dir/GeneratedCodeHelper.cpp.o] Error 1
#5 1550.7 make[3]: Leaving directory '/usr/local/mcrouter/pkgs/fbthrift/build'
#5 1550.7 make[2]: Leaving directory '/usr/local/mcrouter/pkgs/fbthrift/build'
#5 1550.7 make[2]: *** [CMakeFiles/Makefile2:698: thrift/lib/cpp2/CMakeFiles/thriftcpp2.dir/all] Error 2
#5 1550.7 make[1]: *** [Makefile:152: all] Error 2
#5 1550.7 make[1]: Leaving directory '/usr/local/mcrouter/pkgs/fbthrift/build'
#5 1550.7 make: *** [Makefile_ubuntu-20.04:36: .fbthrift-done] Error 2
------
executor failed running [/bin/sh -c apt-get update && apt-get install -y git sudo tzdata &&                 mkdir -p $MCROUTER_DIR/repo &&                 cd $MCROUTER_DIR/repo && git clone $MCROUTER_REPO &&                 cd $MCROUTER_DIR/repo/mcrouter/mcrouter/scripts &&                 ./install_ubuntu_20.04.sh $MCROUTER_DIR &&                 ./clean_ubuntu_14.04.sh $MCROUTER_DIR && rm -rf $MCROUTER_DIR/repo &&                 ln -s $MCROUTER_DIR/install/bin/mcrouter /usr/local/bin/mcrouter]: exit code: 2

Also what happened to versioning? Is v0.41.0 the latest stable release and we should use that branch with Ubuntu 14.04 ?

[kiaplayer]

Same problem here :(

It's a bug in the external repo: facebook/fbthrift#428