facebook/memlab

Keep `@memlab/*` versions in lockstep in package.json

jeswr opened this issue · 1 comments

I've recently encountered the error core_1.browserInfo.recordPuppeteerConfig is not a function. This is similar to #109; and it was encountered in an automated dependabot update (eyereasoner/eye-js#831).

Indeed running npm upgrade to bump the version of @memlab/core fixes the issue; but really I would expect that if @memlab/api uses APIs introduced in v1.1.27 of @memlab/core then @memlab/api should depend on at minimum ^1.1.27 of @memlab/core in the package.json as opposed to v1.1.10 which it is currently set at

"@memlab/core": "^1.1.10",
"@memlab/e2e": "^1.0.9",
"@memlab/heap-analysis": "^1.0.7",
as this would then ensure that tooling like npm and dependabot will upgrade such dependencies in downstream lockfiles when trying to upgrade the version of @memlab/api.

Monorepo tooling such as lerna has native support for this kind of lockstep versioning.

Thank you for reporting this issue. I have updated the minimum version of dependency and published the latest version (memlab@1.1.45).