[iOS][cocoapods] 'RCTAnimation/RCTValueAnimatedNode.h' file not found

Question

[iOS][cocoapods] 'RCTAnimation/RCTValueAnimatedNode.h' file not found

skv-headless opened this issue 8 years ago · 69 comments

Description

'RCTAnimation/RCTValueAnimatedNode.h' file not found.
in current master https://github.com/facebook/react-native/tree/c233191485ef733aa7a8d4ea5c758b9e6a06964c

related to 28 of march changes. @janicduplessis might help
podspec test are passed. @alloy do you have ideas how tests could be improved?
Maybe we need to run xcbuild to test?

Reproduction Steps and Sample Code

https://github.com/skv-headless/AwesomeProject - demo project based on this page https://facebook.github.io/react-native/docs/integration-with-existing-apps.html#cocoapods

Solution

It works if change #import <RCTAnimation/RCTValueAnimatedNode.h> to #import "RCTValueAnimatedNode.h"

Additional Information

Platform: [iOS]
Development Operating System: [MacOS]

Answer 1 · 2017-03-29T12:49:58.000Z

podspec test are passed. @alloy do you have ideas how tests could be improved?
Maybe we need to run xcbuild to test?

Nah, we should ideally build all the subspecs, I’ll take a look at how long those take.

Answer 2 · 2017-03-29T13:10:21.000Z

@skv-headless Your example fails to build from a fresh clone with different issues than the one this ticket is about. Can you make sure it fails with the exact issue you mention from a fresh clone (so no pod install, no npm install) ?

Answer 3 · 2017-03-29T13:11:40.000Z

While enabling full podspec testing I did encounter this failure, which is probably the one you’re referring to:

In file included from /Users/eloy/Code/React/react-native/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.m:10:
/Users/eloy/Code/React/react-native/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.h:12:9: fatal error: 'RCTAnimation/RCTValueAnimatedNode.h' file not found
#import <RCTAnimation/RCTValueAnimatedNode.h>

Answer 4 · 2017-03-29T13:22:35.000Z

Yep. This error. I've updated repo in case it still needed. Are you going to update test script?

Answer 5 · 2017-03-29T13:24:40.000Z

Yeah I’ll do that, and then we’ll see how much time it takes to complete on CI.

Answer 6 · 2017-03-30T12:18:02.000Z

Pushed #13217

Answer 7 · 2017-05-02T23:18:23.000Z

I still get this error even in 0.44.0 where the code in RCTNativeAnimatedModule.h is updated from It works if change #import <RCTAnimation/RCTValueAnimatedNode.h> to #import "RCTValueAnimatedNode.h"

as mentioned by the original Bug logger. So the solution did not work for me.. Any other recommended solutions?

Answer 8 · 2017-05-18T13:34:41.000Z

This is fixed as of 7b7d6bb @skv-headless

Answer 9 · 2017-05-19T13:09:00.000Z

@iggyfisk Is it possible to have a 0.44 fix with this commit ?

Answer 10 · 2017-05-21T06:01:57.000Z

For those who still searching for a quick solution. I was able to launch iOS app with RCTAnimation subspec by including following string to my package.json:

"scripts": {
  "postinstall": "sed -i '' 's\/#import <RCTAnimation\\/RCTValueAnimatedNode.h>\/#import \"RCTValueAnimatedNode.h\"\/' ./node_modules/react-native/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.h",
  ...rest scripts
}

React: 16.0.0-alpha.12
ReactNative: 0.45.0-rc.0

Didn't work for me with above PR which already accepted in 0.45.0-rc.0

Answer 11 · 2017-05-22T16:28:28.000Z

@egorkhmelev same for me. ss.header_dir on Podspec didn't solve this issue.

Answer 12 · 2017-05-24T07:29:45.000Z

@iggyfisk This PR (7b7d6bb) didn't solve this issue (with RN 0.45.0-rc.0) but this one which is closed yes (13217) !!!

Does someone work again on this issue ?

Answer 13 · 2017-05-24T11:14:31.000Z

this is a blocker for us too.. why is the issue closed? (13217)

Answer 14 · 2017-06-16T06:10:07.000Z

Still get this error in RN 0.45.1

Answer 15 · 2017-06-19T21:09:25.000Z

having this error too in v0.45.1

Answer 16 · 2017-06-20T06:08:31.000Z

Getting the error in RN 0.45.1 as well

Answer 17 · 2017-06-20T06:35:11.000Z

Please use this script in package.json script section.

"postinstall": "sed -i '' 's\/#import <RCTAnimation\\/RCTValueAnimatedNode.h>\/#import \"RCTValueAnimatedNode.h\"\/' ./node_modules/react-native/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.h",

It will change #import <RCTAnimation/RCTValueAnimatedNode.h> -> #import "RCTValueAnimatedNode.h

Answer 18 · 2017-06-20T06:40:31.000Z

I use this script and it works but it's not a solution its a patch.. Also some of our teammates are working on Windows macines so this script will not work (I know there's an equivalent for Windows)

The point is that this should be solved the right way without using any hacking..

Answer 19 · 2017-06-20T06:42:24.000Z

Right. Should be fixed

Answer 20 · 2017-07-03T08:56:59.000Z

it seem that this change in RCTNativeAnimatedNodesManager.h does the trick:

before:

after:

Does this make sense? It's working for me on 0.45.1, without running the patch script

Answer 21 · 2017-07-26T10:42:03.000Z

what command should I run after inserting the postinstall script in the package.json?

I tried npm install and pod install but nothing changes

Answer 22 · 2017-07-26T11:52:17.000Z

cd ios && pod install && cd ..

Answer 23 · 2017-07-27T10:52:25.000Z

@littlehome-eugene you can try npm run postinstall

Answer 24 · 2017-08-08T17:14:49.000Z

I got this issue upgrading to react native 0.47.1, any way to resolve it without hacks?

Answer 25 · 2017-09-09T22:37:27.000Z

Does anyone tried to investigate real cause of this problem and find proper solution? All approaches mentioned here and in attached PRs do not look legit and almost certainly will not be merged.

Answer 26 · 2017-09-10T11:19:30.000Z

isn't my solution that was posted here on July 3rd good enough? (the comment with the image attached)

Answer 27 · 2017-09-11T17:26:17.000Z

@guysegal That file is not a part of React module so it cannot be correct solution, right?

Answer 28 · 2017-09-12T07:01:53.000Z

update:
I just upgraded to 0.50.3. Here's what I use in package.json as a temporary solution. Thanks to @younatics .
It solves both RCTValueAnimatedNode.h and fishhook.h import errors. Hope it might save your time.

{
  "scripts": {
    "postinstall": "sed -i '' 's/#import <RCTAnimation\\/RCTValueAnimatedNode.h>/#import <React\\/RCTValueAnimatedNode.h>/' ./node_modules/react-native/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.h; sed -i '' 's/#import <fishhook\\/fishhook.h>/#import <React\\/fishhook.h>/' ./node_modules/react-native/Libraries/WebSocket/RCTReconnectingWebSocket.m"
  },
  "dependencies": {
    ...
  }
}

No luck after upgrading to 0.48.3. Have to use the postinstall script to solve it.

Answer 29 · 2017-09-12T08:09:09.000Z

Did anyone try setting private_header_files? We do use that in a few place in the pod config file. I'm pretty sure it's just a config issue, we should not have to change the import. Sorry about this taking so long to get resolved but we want to make sure we have the right fix.

Answer 30 · 2017-09-13T09:01:45.000Z

@guysegal That file is not a part of React module so it cannot be correct solution, right?

@shergin, which file:
Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.h or Libraries/NativeAnimation/Nodes/RCTValueAnimatedNode.h is not a part of React ?

Answer 31 · 2017-09-13T09:07:00.000Z

@janicduplessis Documentation update needed for private_header_files

Answer 32 · 2017-09-13T16:47:32.000Z

@iegik I assume RCTValueAnimatedNode is part of RCTAnimation. Am I wrong?

Answer 33 · 2017-09-14T09:00:12.000Z

@shergin, Seems to be, You are right. Sorry.
Documentation is needed about adding native Libraries into project.

Answer 34 · 2017-09-27T07:34:50.000Z

Still having this issue using 0.48.3

Answer 35 · 2017-09-27T20:00:12.000Z

@iegik Did the private_header_files thing I mentionned ended up working? It was just a wild guess haha

Answer 36 · 2017-09-28T11:40:46.000Z

@janicduplessis This is not a joke - #15775

Answer 37 · 2017-09-29T00:06:25.000Z

@iegik What do you mean? Do you have an idea how to fix this issue?

Answer 38 · 2017-09-30T13:20:08.000Z

I've asked on the Cocoapods mailing list but I think it is correct to change the import to #import <React/RCTValueAnimatedNode.h>.

I think this is because RCTAnimation is only a subspec and will be built within the React.framework when installed with Cocoapods. If RCTAnimation would be a full-fledged pod then it would be possible to use #import <RCTAnimation/RCTValueAnimatedNode.h>.

Answer 39 · 2017-10-23T07:36:33.000Z

The header file RCTValueAnimatedNode.h is a part of RCTAnimation framework, so it should be

#import "RCTValueAnimatedNode.h" inside RCTAnimation
#import <RCTAnimation/RCTValueAnimatedNode.h> outside RCTAnimation.

Answer 40 · 2017-10-24T08:03:02.000Z

@yimingtang Are you sure about that? I think RCTAnimation isn't built as a full-fledged framework because it gets distributed as a subspec to React (which Cocoapods builds as the framework). So I think it should be:

#import "RCTValueAnimatedNode.h" inside RCTAnimation
#import <React/RCTValueAnimatedNode.h> outside RCTAnimation because RCTValueAnimatedNode is found within React.framework.

There is a similar issue with fishhook as well, see #16271 and #16039.

Answer 41 · 2017-11-10T10:26:46.000Z

Hey guys, no idea what is the status of this with other people... but I am having the compilation error. Fixed it as per suggestion #import <React/RCTValueAnimatedNode.h>

Answer 42 · 2017-11-21T03:16:30.000Z

Still get error with fishhook.h and RCTValueAnimatedNode.h, so I have to change it manually.

Answer 43 · 2017-11-24T05:55:01.000Z

Have some errors after migration to RN 0.50.3

Answer 44 · 2017-11-28T15:44:03.000Z

Same here, please fix this

Answer 45 · 2018-01-02T09:50:51.000Z

In case you guys are not checking the other issue: guykogus provided a "fix" here #16039

Unfortunately, this has been on for sometime now and facebook is not paying attention to this :(

Answer 46 · 2018-01-08T13:52:51.000Z

I think that we should push this up again.
Otherwise we will have always kind of hack on our projects to make them work with Cocoapods.

Thanks!

Answer 47 · 2018-03-01T22:14:33.000Z

Not sure if this will help anyone, but I can avoid this issue if I remove use_frameworks! from my Podfile
If you need to add use_frameworks!, it seems like the postinstall script is the only way..

Answer 48 · 2018-03-09T08:43:06.000Z

There is a common practice that I noticed in quite a few projects that deal with this issue. Here is how it would look like:

#if __has_include(<React/RCTValueAnimatedNode.h>)
#import <React/RCTValueAnimatedNode.h>
#else
#import "RCTValueAnimatedNode.h"
#endif

You can adjust this to your needs, e.g. if you want to cling to #import <RCTAnimation/RCTValueAnimatedNode.h> for whatever reason, then just replace the first and second line appropriately.

This "trick" ensures best compatibility with use_frameworks! and traditional methods.

Answer 49 · 2018-03-09T23:07:24.000Z

Love your suggestion @p2k I think that should be the fix

Answer 50 · 2018-03-09T23:41:26.000Z

Yep, the practice suggested by @p2k seems great.
This could be applied to: #17080 (and dupe) #16271
And also to:
#18050

Removing the need for this postinstall patch:
#17764 (comment)

Answer 51 · 2018-03-12T08:46:02.000Z

Dependency hell / Conflicting dependencies
The roots of this issue goes from v0.40.0 update.
RN team decided to use React/* prefix for importing dependencies. While other RN plugins still may use old importing pattern w/o prefixes. What will cause Duplicate declaration error.

#15448 (comment)
#11721 - maybe a solution

Answer 52 · 2018-03-17T00:42:57.000Z

What build is the React Native team planning to put out a fix for this? Now that Swift has been around for a couple years and use_frameworks! has become commonplace this seems like it really needs a fix. Maybe a trial branch so that folks can report errors and issues before release?

Answer 53 · 2018-03-17T10:59:53.000Z

That is exactly my line. Doing an application completely in react native is practically unfeasible and most new software is been written in swift (and kotlin)

Answer 54 · 2018-03-19T11:52:11.000Z

Duplicate declaration is inherently prevented by ObjC/clang's #import instruction, except if the headers do exist twice, which is prevented with my proposed approach.

Answer 55 · 2018-03-30T11:31:10.000Z

@younatics Your trick worked but i have to remove node_modules folder add the script in package.json and npm install . It worked in my case. Thank you for the trick .

Answer 56 · 2018-04-18T06:14:04.000Z

Hi everyone, I've centralized a lot of the CocoaPods issues into a single project which will apply all of the post-install fixes for you, which should simplify integrating React Native with CocoaPods

https://github.com/orta/cocoapods-fix-react-native

Answer 57 · 2018-06-04T07:57:26.000Z

its sad that even after an year, React-native iOS through Cocoapods is not seamless, you still have to patch around things

Answer 58 · 2018-06-04T12:17:30.000Z

What version are you on @Abdul-Hannan?
The project I'm currently working on uses CocoaPods with React Native 0.55.3 without any issue.

Answer 59 · 2018-06-04T12:41:09.000Z

Hello @jeanregisser , I am using 0.55.4

just added the pods as usual, but got this issue

Answer 60 · 2018-06-04T12:44:39.000Z

Ok, and what version of CocoaPods?

Answer 61 · 2018-06-04T13:10:23.000Z

I am using COCOAPODS: 1.5.0,
avoided issues by using @orta 's https://github.com/orta/cocoapods-fix-react-native

Answer 62 · 2018-06-12T17:56:21.000Z

Please try again with 0.56.0-rc and let us know if that does not resolve the issue by leaving a comment here.

Answer 63 · 2018-06-18T23:48:50.000Z

I can verify that RN 0.56.0-rc.2 does not resolve the issue.

Answer 64 · 2018-06-20T04:57:02.000Z

Yup, it has not been fixed. This issue has been on for more than a year.

Answer 65 · 2018-06-28T10:56:20.000Z

@jeanregisser This is still an issue with RN 0.56.0-rc.4

pod 'React', :path => REACT_NATIVE_PATH, :subspecs => [
    'Core',
    'CxxBridge', # Include this for RN >= 0.47
    'DevSupport', # Include this to enable In-App Devmenu if RN >= 0.43
    'RCTAnimation',
    'RCTActionSheet',
    'RCTBlob',
    'RCTGeolocation',
    'RCTImage',
    'RCTLinkingIOS',
    'RCTNetwork',
    'RCTSettings',
    'RCTText',
    'RCTVibration',
    'RCTWebSocket'
  ]

  # Explicitly include Yoga if you are using RN >= 0.42.0
  pod 'yoga', :path => "#{REACT_NATIVE_PATH}/ReactCommon/yoga"

  # Third party deps podspec link
  pod 'DoubleConversion', :podspec => "#{REACT_NATIVE_PATH}/third-party-podspecs/DoubleConversion.podspec"
  pod 'glog', :podspec => "#{REACT_NATIVE_PATH}/third-party-podspecs/glog.podspec"
  pod 'Folly', :podspec => "#{REACT_NATIVE_PATH}/third-party-podspecs/Folly.podspec"

Answer 66 · 2018-08-10T09:03:25.000Z

try to add this to package.json and run it in your post-install:

"scripts": {
  "fix:ios": "sed -i '' 's/#import <RCTAnimation\\/RCTValueAnimatedNode.h>/#import \"RCTValueAnimatedNode.h\"/' ./node_modules/react-native/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.h"
}

Here is the project template which demonstrates this:
https://www.npmjs.com/package/react-native-vanilla

Answer 67 · 2018-08-22T23:30:25.000Z

I upgraded my react-native to v0.56.0. once I run pod install before building iOS. It works. My solution is

Update react-native@0.56.0
cd ios && pod install
react-native run-ios

Answer 68 · 2018-08-23T17:54:46.000Z

For those who are still experiencing the issue. Try the following:

rm -rf ~/Library/Developer/Xcode/DerivedData/
Inside the ios folder, do
rm -rf "`pwd`/Pods/"
rm -rf "${HOME}/Library/Caches/CocoaPods"
Run pod install
Open xcworkspace
Product > Clean
Product > Clean Folder (Must hold the option key)
Build

Good luck!

Answer 69 · 2018-12-06T15:40:00.000Z

I am using COCOAPODS: 1.5.0,
avoided issues by using @orta 's https://github.com/orta/cocoapods-fix-react-native

This library only removes import strings. that were not automatically linked. It's not a solution to remove import code for fixing bugs because it may cause crash