facebook/react-native

com.facebook.react:react-native:0.19.0 @ReactProp issue on android

soxunyi opened this issue · 8 comments

soxunyi commented

If you use android native view, and annotations ReactProp. Please import the right ReactProp class, import com.facebook.react.uimanager.annotations.ReactProp, rather than import com.facebook.react.uimanager.ReactProp.

com.facebook.react.uimanager.ReactProp is not work on 0.19.0.

Why do not remove this class on 0.19.0?

facebook-github-bot commented

Hey soxunyi, thanks for reporting this issue!

React Native, as you've probably heard, is getting really popular and truth is we're getting a bit overwhelmed by the activity surrounding it. There are just too many issues for us to manage properly.

  • If you don't know how to do something or something is not working as you expect but not sure it's a bug, please ask on StackOverflow with the tag react-native or for more real time interactions, ask on Discord in the #react-native channel.
  • If this is a feature request or a bug that you would like to be fixed, please report it on Product Pains. It has a ranking feature that lets us focus on the most important issues the community is experiencing.
  • We welcome clear issues and PRs that are ready for in-depth discussion. Please provide screenshots where appropriate and always mention the version of React Native you're using. Thank you for your contributions!
rpopovici commented

temporary fix for this is to add the following to your build.gradle

android {
...
lintOptions {
warning 'InvalidPackage'
}
}

dependencies {
...
compile 'com.facebook.react:react-native:0.19.+'
}

and then import com.facebook.react.uimanager.annotations.ReactProp

deminoth commented

+1. import com.facebook.react.uimanager.ReactProp does not showing any error but not working. We should notify using import com.facebook.react.uimanager.annotations.ReactProp to developer.

janicduplessis commented

This was a breaking change in 0.19, sorry if it was not communicated properly.

facebook-github-bot commented

Closing this issue as @janicduplessis says the question asked has been answered. Please help us by asking questions on StackOverflow. StackOverflow is amazing for Q&A: it has a reputation system, voting, the ability to mark a question as answered. Because of the reputation system it is likely the community will see and answer your question there. This also helps us use the GitHub bug tracker for bugs only.

taypo commented

Lost two days on this. Please make a remark on the documentation.

  • 👍4
fiattt commented

Lost one days on this - -!

  • 😕1