facebookarchive/bAbI-tasks

babi/utilities.lua line 89: is this a bug?

yujiali opened this issue · 1 comments

yujiali commented 
function Grid:to_coordinates(i)
    return (i - 1) % self.width + 1, math.floor((i - 1) / 10) + 1
end

Should the number 10 here actually be self.width?

bartvm commented

Yes, seems like that was left over from when the Grid class still had a fixed size, fixed in 0a7e05c.