facebookarchive/thpp

fbthrift got no stable version to support compling TH++, is GeneratedHeaderHelper optional?

Opened this issue · 2 comments

When building TH++, there is this line in thpp/build/thpp/if/gen-cpp2/Tensor_type.h:

#include <thrift/lib/cpp2/GeneratedHeaderHelper.h>

But at Thrift v0.24, there is no such file.
So, Thrift & Folly can be installed successfully, but when it comes to TH++, I got an error like:

cannot find GeneratedHeaderHelper.h

Since Thrift v2016.09.26 , this file has been added, but according to the README of Thrift, it seems none of those new version can be built completely.

T.T..................... I have tried paste this file from new version into the folder of v0.24, or comment that line , all lead to this new issue:

Scanning dependencies of target thpp
[  7%] Building CXX object CMakeFiles/thpp.dir/Storage.cpp.o
In file included from /home/amax/LavieC/CRNN_ENV/thpp/thpp/../thpp/Storage.h:15:0,
                 from /home/amax/LavieC/CRNN_ENV/thpp/thpp/Storage.cpp:11:
/home/amax/LavieC/CRNN_ENV/thpp/thpp/build/thpp/if/gen-cpp2/Tensor_types.h:32:47: error: ‘TEnumMapFactory’ in namespace ‘apache::thrift::detail’ does not name a template type
 extern const typename apache::thrift::detail::TEnumMapFactory<ThriftTensorDataType, ThriftTensorDataType>::ValuesToNamesMapType _ThriftTensorDataType_VALUES_TO_NAMES;

Now I got no idea how to install all the dependencies of fblualib, wish you guys could solve this problem.

same problem

Same here