facebookincubator/fizz

Can't build with proxygen's build.sh nor with internal build.sh since today

orestdrag opened this issue · 1 comments

Seems like after the last changes something was broken.
Here is the commit info

commit a2c1684 (HEAD, origin/main, origin/HEAD, main)
Author: Nick Richardson richardsonnick@meta.com
Date: Tue Oct 18 22:03:23 2022 -0700

error msg:
[100%] Linking CXX executable bin/fizz
.text._ZN4fizz6client16AsyncFizzClientTINS0_18ClientStateMachineEE17ActionMoveVisitorclERNS_15SecretAvailableE' referenced in section .note.stapsdt' of CMakeFiles/FizzTool.dir/tool/FizzClientLoadGenCommand.cpp.o: defined in discarded section .text._ZN4fizz6client16AsyncFizzClientTINS0_18ClientStateMachineEE17ActionMoveVisitorclERNS_15SecretAvailableE[_ZN4fizz6client16AsyncFizzClientTINS0_18ClientStateMachineEE17ActionMoveVisitorclERNS_15SecretAvailableE]' of CMakeFiles/FizzTool.dir/tool/FizzClientLoadGenCommand.cpp.o .text._ZN4fizz6server16AsyncFizzServerTINS0_18ServerStateMachineEE17ActionMoveVisitorclERNS_15SecretAvailableE' referenced in section .note.stapsdt' of CMakeFiles/FizzTool.dir/tool/FizzServerCommand.cpp.o: defined in discarded section .text._ZN4fizz6server16AsyncFizzServerTINS0_18ServerStateMachineEE17ActionMoveVisitorclERNS_15SecretAvailableE[_ZN4fizz6server16AsyncFizzServerTINS0_18ServerStateMachineEE17ActionMoveVisitorclERNS_15SecretAvailableE]' of CMakeFiles/FizzTool.dir/tool/FizzServerCommand.cpp.o
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/FizzTool.dir/build.make:196: bin/fizz] Error 1
make[1]: *** [CMakeFiles/Makefile2:82: CMakeFiles/FizzTool.dir/all] Error 2
make: *** [Makefile:152: all] Error 2

OS: Ubuntu 20.04 used in docker

Thanks for bringing this to our attention. We'll revert this for now and investigate -- it appears to be a difference between using GNU LD (this is what you are using / is the default) and LLVM LLD (which we use internally).