facebookincubator/fizz

[regression in 2023.06.12.00] libfizz.so.1.0.0: undefined reference to softaes_block_encrypt

yurivict opened this issue · 2 comments

proxygen fails to build because of the mising symbol in libfizz.so:

ld: error: /usr/local/lib/libfizz.so.1.0.0: undefined reference to softaes_block_encrypt [--no-allow-shlib-undefined]

See facebook/proxygen#450

FreeBSD 13.2

This patch fixes it:

--- CMakeLists.txt.orig 2023-06-17 04:33:21 UTC
+++ CMakeLists.txt
@@ -233,6 +233,7 @@ set(FIZZ_SOURCES
   third-party/libsodium-aegis/aegis256/aesni/aead_aegis256_aesni.c
   third-party/libsodium-aegis/aegis256/armcrypto/aead_aegis256_armcrypto.c
   third-party/libsodium-aegis/aegis256/soft/aead_aegis256_soft.c
+  third-party/libsodium-aegis/private/softaes.c
 )
 
 add_library(fizz

Hey yurivict,

Thanks for bringing this to our attention. The fix has been committed: 0dc415e