facebookresearch/FLSim

For the cifar10 example calculate delta function issue

shou123 opened this issue · 1 comments

shou123 commented

🐛 Bug

I debug the cifar10 example. For '''flsim/clients/base_client.py -> delta = self.compute_delta()''' pass the three-parameter "before", "after" and "model_to_save". And '''after=updated_model, model_to_save=updated_model''' And for the compute_delta function, it is return updated_model, it didn't calculate any difference.

To Reproduce

⚠️ We cannot help you without you sharing reproducible code. Do not ignore this part :)
Steps to reproduce the behavior:

Expected behavior

Environment

Please copy and paste the output from our
environment collection script
(or fill out the checklist below manually).

You can get the script and run it with:

wget https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py
# For security purposes, please check the contents of collect_env.py before running it.
python collect_env.py
  • PyTorch Version (e.g., 1.0):
  • OS (e.g., Linux):
  • How you installed PyTorch (conda, pip, source):
  • Build command you used (if compiling from source):
  • Python version:
  • CUDA/cuDNN version:
  • GPU models and configuration:
  • Any other relevant information:

Additional context

JohnlNguyen commented

Hey, can you provide a notebook on how we can reproduce this bug? We have a unit test which tested this function.
https://github.com/facebookresearch/FLSim/blob/main/flsim/clients/tests/test_client.py#L288